Conversation
added out/ (IntelliJ) to .gitignore Signed-off-by: Vest <Vest@users.noreply.github.com>
|
I think it is possible to improve the fix by using try-with-resources for Kotlin. Unfortunately, the supported JDK should be increased from 1.6 (default for Kotlin) to 1.7 (1.8). E.g. Can/should I try this option? |
|
Thanks for this. Unfortunately(-ish), I had also fixed the bug (and then forgot to push the code). Since the problem originates from ResultSets being open (which are implicitly closed by calling Statement.close()), my code looks at closing them explicitly after they're used. As for bumping up the kotlin-stdlib: I'll have a look into that. |
|
Ok, it is up to you to decide what to do with the PR. Stdlib has "use" extension, it might help you to improve the mess with statements & result sets. If you have reviewed my PR and don't need any change, feel free to close it. |
|
@fabianonline please merge =) |
Fixed issue #94 by closing open statements
added out/ (IntelliJ) to .gitignore